HDDS-15281. Missing LifeCycleState codec in ScmCodecFactory#10276
Merged
Conversation
HDDS-15281. Missing LifeCycleState codec in ScmCodecFactory HDDS-15281. Missing LifeCycleState codec in ScmCodecFactory
adoroszlai
reviewed
May 15, 2026
adoroszlai
reviewed
May 15, 2026
adoroszlai
approved these changes
May 15, 2026
Contributor
|
Thanks @sarvekshayr for updating the patch. |
Contributor
Author
|
Thanks @sumitagrawl and @adoroszlai for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerStateManager#transitionDeletingOrDeletedToTargetStateis annotated with@Replicateand takesorg.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleStateas a parameter. After HDDS-14748 (non-reflectionScmGeneratedMessageCodec/ explicit codec registration for Ratis serialization), callers need aScmCodecregistered for every protobuf-derived type used in replicated method arguments—including protobuf enums handled viaScmEnumCodec.LifeCycleStatewas not registered inScmCodecFactory. That can causeInvalidProtocolBufferException(“Codec not found …”) when the leader submits or followers apply this Ratis transaction.What is the link to the Apache JIRA
HDDS-15281
How was this patch tested?
Added a new test to scan every
@Replicatemethod on known SCM handlers and asserts each parameter type resolves to a codec.